Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dockers] update mellanox syncd and pmon to buster #4818

Merged
merged 1 commit into from
Jul 18, 2020
Merged

[dockers] update mellanox syncd and pmon to buster #4818

merged 1 commit into from
Jul 18, 2020

Conversation

stepanblyschak
Copy link
Collaborator

@stepanblyschak stepanblyschak commented Jun 19, 2020 •
edited
Loading

Signed-off-by: Stepan Blyschak stepanb@mellanox.com

- Why I did it

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@lguohan
Copy link
Collaborator

lguohan commented Jun 19, 2020

looks like some build failure

@stepanblyschak
Copy link
Collaborator Author

@lguohan mellanox build requires Mellanox/Switch-SDK-drivers#17, but i shared PR right now so you are able to test buster pmon on non mellanox platforms

@liat-grozovik
Copy link
Collaborator

Retest mellanox please

@stepanblyschak stepanblyschak force-pushed the buster_dockers_upgrade branch 4 times, most recently from 808a85f to a8f3a2c Compare July 1, 2020 07:19
@stepanblyschak
Copy link
Collaborator Author

@lguohan
There is an issue with ctypesgen==0.r125 during saithrift compilation:

Status: gcc -E -U __GNUC__ -dD -I/usr/include -I/usr/include/sai "-Dinline=" "-D__inline__=" "-D__extension__=" "-D_Bool=uint8_t" "-D__const=const" "-D__asm__(x)=" "-D__asm(x)=" "-DCTYPESGEN=1" /tmp/tmpAR8Dwz.h
Traceback (most recent call last):
  File "/usr/local/bin/ctypesgen.py", line 136, in <module>
    descriptions=ctypesgencore.parser.parse(options.headers,options)
  File "/usr/local/lib/python2.7/dist-packages/ctypesgencore/parser/__init__.py", line 21, in parse
    parser.parse()
  File "/usr/local/lib/python2.7/dist-packages/ctypesgencore/parser/datacollectingparser.py", line 69, in parse
    ctypesparser.CtypesParser.parse(self, fname, None)
  File "/usr/local/lib/python2.7/dist-packages/ctypesgencore/parser/cparser.py", line 113, in parse
    self.preprocessor_parser.parse(filename)
  File "/usr/local/lib/python2.7/dist-packages/ctypesgencore/parser/preprocessor.py", line 200, in parse
    token = self.lexer.token()
  File "/usr/local/lib/python2.7/dist-packages/ctypesgencore/parser/preprocessor.py", line 51, in token
    result = lex.Lexer.token(self)
  File "/usr/local/lib/python2.7/dist-packages/ctypesgencore/parser/lex.py", line 297, in token
    newtok = func(tok)
  File "/usr/local/lib/python2.7/dist-packages/ctypesgencore/parser/pplexer.py", line 218, in t_ANY_int
    g1 = str(long(g1,8))
ValueError: invalid literal for long() with base 8: '08420217248550443400745280086994171'

Updated ctypesgen to 1.0.2, but it requires this fix in SAI opencomputeproject/SAI#1111

@stepanblyschak stepanblyschak force-pushed the buster_dockers_upgrade branch 3 times, most recently from 2261fd1 to e7cb366 Compare July 10, 2020 13:22
[dockers] update mellanox syncd and pmon to buster
f892666 
Updated sonic-sairedis pointer:
    d54bfb4 [SAI] update pointer (sonic-net#636)
    1885a8c [syncd] Fix notification on shutdown request (sonic-net#635)
    9e57ba2 Fixing hostif For Genetlink host interfaces (sonic-net#633)
    449a092 sonic-sairedis: Add support to sonic-sairedis for gearbox phys (sonic-net#632)

Signed-off-by: Stepan Blyschak <stepanb@mellanox.com>
@stepanblyschak
Copy link
Collaborator Author

retest broadcom please

@stepanblyschak stepanblyschak marked this pull request as ready for review July 15, 2020 18:29
@stepanblyschak
Copy link
Collaborator Author

retest vsimage please

@lguohan lguohan merged commit 16a37d8 into sonic-net:master Jul 18, 2020
@akokhan
Copy link
Contributor

akokhan commented Jul 20, 2020

@stepanblyschak this PR has updated sairedis without even mentioning that... at least sairedis commits should be listed in the description. Thanks.

@stepanblyschak stepanblyschak deleted the buster_dockers_upgrade branch September 23, 2022 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stepanblyschak @lguohan @liat-grozovik @akokhan